Skip to content

docs(building-plugins): document npm plugin sources#1227

Merged
factory-davidgu merged 3 commits into
mainfrom
dgu/docs-npm-plugin-source
Jun 15, 2026
Merged

docs(building-plugins): document npm plugin sources#1227
factory-davidgu merged 3 commits into
mainfrom
dgu/docs-npm-plugin-source

Conversation

@factory-davidgu

@factory-davidgu factory-davidgu commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Documents the new npm plugin source type for marketplace manifests in guides/building/building-plugins.mdx.

What changed

  • Added a new Plugin sources subsection under Distributing plugins -> Creating a marketplace, summarizing the supported plugin source types (relative path, github, url, git-subdir, npm).
  • Added a focused npm packages subsection covering:
    • Minimal, version-pinned, and private-registry examples
    • Field reference (package, version, registry)
    • Published package layout requirements (Droid + Claude Code formats both accepted; Claude format translated at install)
    • Recommended package.json files configuration
    • Install-time hardening (--ignore-scripts, scratch-scoped .npmrc)
  • Added a Wrapper marketplace snippet showing how to ship a single npm-published plugin without standing up a full marketplace repo, including a CLI quick start.
  • Called out that npm: is not a valid marketplace source.

Notes

  • All examples use placeholder identifiers (@your-org/droid-pr-triage, your-org-plugins, https://npm.your-org.example). No real published packages are referenced.
  • The companion runtime change lives in factory-mono on dgu/npm-marketplace.

@factory-droid

factory-droid Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Droid finished @factory-davidgu's task —— View job


Security Review

Review summary

Solid, detailed docs for the new npm plugin source. A couple small clarifications around pinning/versioning semantics across source types will prevent readers from applying the marketplace (git commit hash) guidance to npm-based installs.

Document the npm plugin source for marketplace manifests, including
required/optional fields, the published package layout (Droid and
Claude Code formats), install-time hardening defaults, and the
wrapper-marketplace pattern for shipping a single npm-published
plugin.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@mintlify

mintlify Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
factory 🟢 Ready View Preview Jun 13, 2026, 1:00 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Comment thread docs/guides/building/building-plugins.mdx
Comment thread docs/guides/building/building-plugins.mdx Outdated
factory-ain3sh
factory-ain3sh previously approved these changes Jun 13, 2026

@factory-ain3sh factory-ain3sh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls address review droid feedback before merging

factory-davidgu and others added 2 commits June 15, 2026 15:51
…pm install constraints

Addresses PR #1227 review feedback by disambiguating per-source pinning
behavior (git ref/sha vs marketplace ref vs npm version) and scoping the
existing git-commit-hash note to git-based sources. Also documents the
runtime-enforced constraints from factory-mono#14467: registry URLs must
be https with no credentials/query/fragment, version specs cannot be
file:/git+/url/path/npm: aliases, the npm CLI must be on PATH, and
postinstall-built packages must publish prebuilt artifacts because
--ignore-scripts skips lifecycle scripts.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

@factory-ain3sh factory-ain3sh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@factory-davidgu factory-davidgu merged commit 7564dbb into main Jun 15, 2026
4 checks passed
@factory-davidgu factory-davidgu deleted the dgu/docs-npm-plugin-source branch June 15, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants